main/bromal
Watch
2
1
Fork
You've already forked bromal
 1
Code Issues 19 Pull requests Projects Releases Packages 1 Wiki Activity Actions

[10] Create schema files for e2ee tables #34

Merged
serra merged 2 commits from serra/e2ee into feature/e2ee 2026-09-22 14:27:20 +03:00
Conversation 3 Commits 2 Files changed 12 +413 -61
serra commented 2026-09-17 05:54:38 +03:00
Owner
Copy link

PR in support of issue #10

Implementing schema files for e2ee tables, with some modifications related to adding a sender field to the DeviceMessage schema.

Also some tweaks to the migration file after a couple of realizations.

PR in support of issue #10 Implementing schema files for e2ee tables, with some modifications related to adding a `sender` field to the `DeviceMessage` schema. Also some tweaks to the migration file after a couple of realizations.
serra self-assigned this 2026-09-17 05:54:38 +03:00
[10] Create schema files for e2ee tables
All checks were successful
run bromal ci pipeline / build and run tests (push) Successful in 4m12s
Details
run bromal ci pipeline / run linters (push) Successful in 5m14s
Details
run bromal ci pipeline / generate sbom (push) Successful in 3m39s
Details
e95cf4e10e
 
#10

Signed-off-by: Serra Allgood <serra@allgood.dev>
serra requested review from igor 2026-09-17 05:54:44 +03:00
igor requested changes 2026-09-20 19:55:40 +03:00
igor left a comment
Copy link

Some small nitpicks, else seems to be ok according to the visual review.

Some small nitpicks, else seems to be ok according to the visual review.
lib/bromal/schemas/cross_signing_key.ex Outdated
@ -0,0 +24,4 @@
alias Bromal.Types
@primary_key false
igor commented 2026-09-20 19:32:14 +03:00
Owner
Copy link

I would remove empty line here to make attribute to be closer to schema definition.

I would remove empty line here to make attribute to be closer to schema definition.
serra marked this conversation as resolved
lib/bromal/schemas/cross_signing_key.ex Outdated
@ -0,0 +26,4 @@
@primary_key false
schema "cross_signing_keys" do
field :user_id, Types.Ecto.UserId, writable: :insert, writable: :insert
igor commented 2026-09-20 19:36:09 +03:00
Owner
Copy link

writable: :insert is defined twice. I think, there should be only once.

`writable: :insert` is defined twice. I think, there should be only once.
serra marked this conversation as resolved
lib/bromal/schemas/key_backup_version.ex Outdated
@ -0,0 +26,4 @@
@primary_key {:id, :binary_id, autogenerate: true}
@foreign_key_type :binary_id
igor commented 2026-09-20 19:43:39 +03:00
Owner
Copy link

I would remove empty line here to make attributes to be closer to schema definition.

I would remove empty line here to make attributes to be closer to schema definition.
serra marked this conversation as resolved
lib/bromal/schemas/one_time_key.ex Outdated
@ -0,0 +25,4 @@
@primary_key {:id, :binary_id, autogenerate: true}
@foreign_key_type :binary_id
igor commented 2026-09-20 19:45:53 +03:00
Owner
Copy link

I would remove empty line here to make attributes to be closer to schema definition.

I would remove empty line here to make attributes to be closer to schema definition.
serra marked this conversation as resolved
[10] Make requested changes from review
All checks were successful
run bromal ci pipeline / build and run tests (push) Successful in 6m18s
Details
run bromal ci pipeline / run linters (push) Successful in 6m44s
Details
run bromal ci pipeline / generate sbom (push) Successful in 4m53s
Details
7288fe6939
 
Signed-off-by: Serra Allgood <serra@allgood.dev>
serra requested review from igor 2026-09-22 14:25:33 +03:00
serra commented 2026-09-22 14:25:54 +03:00
Author
Owner
Copy link

Changes made!

Changes made!
serra commented 2026-09-22 14:26:58 +03:00
Author
Owner
Copy link

Gonna go ahead and merge into the feature branch

Gonna go ahead and merge into the feature branch
serra merged commit 7288fe6939 into feature/e2ee 2026-09-22 14:27:20 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
igor
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
qa
Task to be tested by QA

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
qa
question
wontfix
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
serra
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
main/bromal!34
No description provided.