[10] Create embedded_schemas for e2ee endpoints #35

serra · 2026-09-25T11:01:54+03:00

serra commented

2026-09-25 11:01:54 +03:00

PR in support of #10.

May have gone a little overboard with some of the request validations here.

PR in support of #10. May have gone a little overboard with some of the request validations here.

serra added 5 commits

2026-09-25 11:01:54 +03:00

[10] Create Requests for device_signing and signatures_upload d274ed95f9

Signed-off-by: Serra Allgood <serra@allgood.dev>

[10] Create RoomKeyPuts requests type.

run bromal ci pipeline / build and run tests (push) Successful in 4m48s

Details

run bromal ci pipeline / run linters (push) Successful in 5m29s

Details

run bromal ci pipeline / generate sbom (push) Successful in 4m10s

Details

5c8ba99f5a

Along with supporting embedded types.

Signed-off-by: Serra Allgood <serra@allgood.dev>

[10] Create Requests.Keys.Claim type fab6754612

Signed-off-by: Serra Allgood <serra@allgood.dev>

[10] Create Requests.Client.Keys.Query type 4ef6968b3b

Signed-off-by: Serra Allgood <serra@allgood.dev>

[10] Create Requests.Client.Keys.Upload

run bromal ci pipeline / build and run tests (push) Successful in 5m11s

Details

run bromal ci pipeline / run linters (push) Successful in 6m2s

Details

run bromal ci pipeline / generate sbom (push) Successful in 4m14s

Details

31e5245471

Signed-off-by: Serra Allgood <serra@allgood.dev>

serra reviewed

2026-09-25 11:02:37 +03:00

priv/repo/migrations/00000000000000_create_initial_tables.exs

					
				@ -656,3 +656,3 @@

				      add :user_id, :string, null: false

				      add :algorithms, {:array, :string}

				      add :public_key, :string, null: false

				      add :keys, :map, null: false

Realized that this column mapping makes things a whole lot easier for parsing and storing device keys

serra commented

2026-09-25 11:03:47 +03:00

Wasn't sure if the supporting request types should be under the Bromal.Types module or yet another layer under Bromal.Request.Client.Keys

Wasn't sure if the supporting request types should be under the `Bromal.Types` module or yet another layer under `Bromal.Request.Client.Keys`

serra

2026-09-25 11:03:58 +03:00

added the
enhancement
label
requested review from igor

serra added this to the Security/encryption features milestone

2026-09-25 11:04:09 +03:00

serra self-assigned this

2026-09-25 11:04:15 +03:00

serra commented

2026-09-25 11:04:42 +03:00

Random aside, but with this PR, there are exactly 1000 test cases in Bromal now! 🎉

🎉 1

serra changed title from ~~Create embedded_schemas for e2ee endpoints~~ to [10] Create embedded_schemas for e2ee endpoints

2026-09-25 11:05:22 +03:00

igor reviewed

2026-09-26 21:56:32 +03:00

test/bromal/requests/client/keys/claim_test.exs Outdated

					
				@ -0,0 +26,4 @@

				  describe "claim form" do

				    test "parse/1 returns data with user id strings converted to Types.UserId" do

				      user_1 = user_fixture()

For future: I would use user1 and user2 instead of user_1 and user_2 for consistency with other places.

For future: I would use `user1` and `user2` instead of `user_1` and `user_2` for consistency with other places.

👍 1

igor approved these changes

2026-09-26 22:00:37 +03:00

igor left a comment

Seems to be OK.

For future: the constructions like ... |> map |> filter |> map ... I would rewrite to use Stream module instead of Enum. You can leave it as is, at least for now.

Seems to be OK. For future: the constructions like `... |> map |> filter |> map ...` I would rewrite to use `Stream` module instead of `Enum`. You can leave it as is, at least for now.

igor commented

2026-09-26 22:03:32 +03:00

@serra wrote in #35 (comment):

Random aside, but with this PR, there are exactly 1000 test cases in Bromal now! 🎉

Hey, I'm finishing tests for CLI/RPC now and thought, that I will want to boast about this number overflow. :)

@serra wrote in https://code.bromal.im/main/bromal/pulls/35#issuecomment-180: > Random aside, but with this PR, there are exactly 1000 test cases in Bromal now! :tada: Hey, I'm finishing tests for CLI/RPC now and thought, that I will want to boast about this number overflow. :)

igor commented

2026-09-26 22:07:58 +03:00

@serra wrote in #35 (comment):

Wasn't sure if the supporting request types should be under the Bromal.Types module or yet another layer under Bromal.Request.Client.Keys

I suppose, the second variant is better. Under the Bromal.Types we have more primitive and generic types.

@serra wrote in https://code.bromal.im/main/bromal/pulls/35#issuecomment-175: > Wasn't sure if the supporting request types should be under the `Bromal.Types` module or yet another layer under `Bromal.Request.Client.Keys` I suppose, the second variant is better. Under the `Bromal.Types` we have more primitive and generic types.

serra added 1 commit

2026-09-29 12:13:08 +03:00

[10] PR feedback changes

run bromal ci pipeline / build and run tests (push) Failing after 3m56s

Details

run bromal ci pipeline / run linters (push) Has been skipped

Details

run bromal ci pipeline / generate sbom (push) Has been skipped

Details

7cf4a696b8

- Rename test variables
- Move supporting embedded schemas for keys
requests to their own folder but not module

Signed-off-by: Serra Allgood <serra@allgood.dev>

serra force-pushed serra/e2ee from 7cf4a696b8

run bromal ci pipeline / build and run tests (push) Failing after 3m56s

Details

run bromal ci pipeline / run linters (push) Has been skipped

Details

run bromal ci pipeline / generate sbom (push) Has been skipped

Details

to ca011c13c1

run bromal ci pipeline / generate sbom (push) Successful in 4m59s

Details

run bromal ci pipeline / build and run tests (push) Successful in 6m2s

Details